-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update main #3314
Merged
Merged
chore: Update main #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Feel free to delete comments as you fill this in --> <!-- summary of changes --> ## Changes - removed generation of integration_tests file - added a print for the user to create the integration tests manually - changed the `ShowByIdOperation` name to `ShowByIdOperationNoFiltering` for no automatic generation of filtering options - adjusted the template for ShowByID filtering - removed `ShowByIDNoFiltering` option (replaced by `ShowByIdOperationNoFiltering`) - adjusted README of the SDK generator to the current state ## References <!-- issues documentation links, etc --> * #3227 * #3240
- Add external removal tests to functions and procedures (done during old issues closing) - Fix the following tests: - TestAcc_FunctionJava_InlineFull - TestAcc_FunctionPython_InlineBasic - TestAcc_FunctionPython_InlineFull - TestAcc_FunctionScala_InlineFull - TestAcc_FunctionSql_InlineBasic
Fix tests after V1: - TestAcc_Functions - TestAcc_Procedures - TestAcc_ExternalFunction_complete - TestAcc_GrantOwnership_OnObject_ProcedureWithArguments_ToAccountRole - TestAcc_GrantOwnership_OnObject_ProcedureWithoutArguments_ToDatabaseRole - extended authenticator unit test - Parameters tests were not altered but the environment was adjusted (to verify if they will still fail) Additionally: - added 3 missing preview features (2 needed for tests and 1 just missing for completion)
- generate marshal and `depends_on` for each resource and data source model - replace deprecated `FromModel` with the new one utilizing the aforementioned marshaling - fix test with explicit empty list (and add it to special variables) - fix tests with explicit null value (and add it to special variables) - generalize multiline handling and test it - use multiline strings for definitions in functions and procedures config builders - simplify function and procedure definitions - format whitespace in function and procedure definitions For the next PRs (added to the issue): - current config building for functions/procedures (especially definitions) is complex: - definition is build using multiline golang strong and sprintf - whitespace is formatted - this is added in the config builder wrapped in special multiline marker - hcl-compatible json is generated - json converted to hcl - hcl formatted using custom formatters This should be refined and made simpler (e.g. newline replacement, encoding problems, etc.) - marking in config builders generators which fields should be handled as multiline by default (because now e.g. SQL function requires the definition, so it's generated in basic builder as a string input, and not the multiline one; because of that it has to be added again with `WithFunctionDefinitionValue(...)` which is confusing)
<!-- Feel free to delete comments as you fill this in --> - Add missing parameters based on the docs and output of SHOW PARAMETERS IN ACCOUNT - Add missing unit tests and implementations - Add missing validations - Relax validations for ints - just validate if they are non-negative - Update docs <!-- summary of changes --> ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [ ] acceptance tests <!-- add more below if you think they are relevant --> * [ ] … ## References <!-- issues documentation links, etc --> #3044 #3116 #3245 ## TODO - Do not add missing user parameters - this will be done in SNOW-1844996. Here, they are added only to account and session level - More acceptance and integration tests should be done on a separate account. This should be done during account resource follow-up (SNOW-1866453)
Integration tests cancelled for c82f453fc198b98a582c668ce0dbd4900cfc642a |
Integration tests cancelled for 655d0e54d48968bd5aa8217912d4114dfcbcadb6 |
sfc-gh-jmichalak
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update main